ABI and Calling Conventions: Review Checklist

Review checklist

Review Checklist for ABI and Calling Conventions centers on call/return overhead cycles, register spill rate, and stack bandwidth pressure. Tie every claim to a measurable artifact and an owner-controlled action.

• Workload scope and KPI targets are explicit.

• Environment metadata is locked and reproducible.

• Stage-loss classification is backed by evidence.

• Owner and rollback conditions are documented.

• Validation matrix covers perf, correctness, and power.

• Owners signed: compiler backend owner, runtime ABI owner, performance engineer.

CPU deep dive

ISA choices are software contracts that directly become decode, verification, and security cost in silicon.

Concept diagram

ISA CONTRACT STACK

instruction semantics -> encoding -> decode/uOP expansion -> architectural state

Metric graph

ISA HEALTH TREND

illegal encoding escapes     █
decode expansion pressure    ████
ABI mismatch incidents       ██

Reports and artifacts

• instruction legality audit

• decode critical-path report

• ABI conformance summary

• trap/CSR latency sheet

Mini case study

A late ISA extension looked harmless but increased decode expansion ratio and pushed front-end timing beyond closure margin.

Debug branches

• Map each ISA feature to decode and retire implications

• Separate architectural correctness from microarchitectural cost

• Validate privileged behavior with precise-state traces

Senior review question

Ask: which CPI/latency evidence proves this topic is truly closed beyond synthetic benchmarks?

Key takeaways

• Always connect microarchitectural counter changes to product workload outcomes.

• Lock binary, compiler, firmware, and thermal metadata before comparing CPU traces.

Common pitfalls

• Treating average IPC as sufficient proof while ignoring latency tails and outliers.

• Applying predictor or prefetch tweaks without first-failing-stage attribution.

• Declaring closure without reproducible perf, correctness, and power gates.

Review checklist explanation

A checklist here prevents false confidence. Every item should defend against a known closure failure mode.

For ABI and Calling Conventions, minimum checklist: workload scope, call/return overhead cycles, register spill rate, and stack bandwidth pressure, artifact evidence (calling-convention compliance report, prologue/epilogue profile, and spill heatmap), bottleneck class, owner, rollback path, and full-matrix validation.

If architecture or RTL changed, include correctness, power, timing, and observability checks. If software policy changed, include compatibility and deployment safety evidence.